From 2f62f6d876ce9622a7b082d4d55a4cb4a3e556ae Mon Sep 17 00:00:00 2001 From: bjorn3 <17426603+bjorn3@users.noreply.github.com> Date: Wed, 28 Oct 2026 20:52:47 +0100 Subject: [PATCH] Set umask to 022 while building disk images This matches the default umask that would actually be used at runtime. It ensures only the owner has write permissions to system files and directories rather than owner and group. The Arti tor implementation checks that /home is not writable for anyone other than the owner. --- mk/disk.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mk/disk.mk b/mk/disk.mk index dd5ae1f24..c678db844 100644 --- a/mk/disk.mk +++ b/mk/disk.mk @@ -13,7 +13,7 @@ else FILESYSTEM_SIZE=$(shell $(INSTALLER) --filesystem-size -c $(FILESYSTEM_CONFIG)); \ fi && \ truncate -s "$$FILESYSTEM_SIZE"m $@.partial - umask 002 && $(INSTALLER) $(INSTALLER_OPTS) -c $(FILESYSTEM_CONFIG) $@.partial + umask 022 && $(INSTALLER) $(INSTALLER_OPTS) -c $(FILESYSTEM_CONFIG) $@.partial mv $@.partial $@ endif @@ -29,7 +29,7 @@ else FILESYSTEM_SIZE=$(shell $(INSTALLER) --filesystem-size -c $(FILESYSTEM_CONFIG)); \ fi && \ truncate -s "$$FILESYSTEM_SIZE"m $@.partial - umask 002 && $(INSTALLER) $(INSTALLER_OPTS) -c $(FILESYSTEM_CONFIG) --write-bootloader="$(BUILD)/bootloader-live.efi" --live $@.partial + umask 022 && $(INSTALLER) $(INSTALLER_OPTS) -c $(FILESYSTEM_CONFIG) --write-bootloader="$(BUILD)/bootloader-live.efi" --live $@.partial mv $@.partial $@ cp redox.ipxe $(BUILD)/redox.ipxe endif @@ -52,7 +52,7 @@ else $(REDOXFS) $@.partial $(MOUNT_DIR) sleep 1 pgrep redoxfs - umask 002 && $(INSTALLER) $(INSTALLER_OPTS) -c $(FILESYSTEM_CONFIG) $(MOUNT_DIR) + umask 022 && $(INSTALLER) $(INSTALLER_OPTS) -c $(FILESYSTEM_CONFIG) $(MOUNT_DIR) sync -$(FUMOUNT) $(MOUNT_DIR) || true rm -rf $(MOUNT_DIR)